[CRIU] [PATCH] arch/x86: Fix calculation of xstate_size

Cyrill Gorcunov gorcunov at gmail.com
Mon Jun 1 11:28:14 MSK 2020


On Mon, Jun 01, 2020 at 09:17:34AM +0100, Radostin Stoyanov wrote:
> 
> 
> On 31/05/2020 21:51, Cyrill Gorcunov wrote:
> > On Sun, May 31, 2020 at 12:57:30PM -0700, Andrei Vagin wrote:
> > > > > Dima, could you review this patch?
> > > > > Cyrill, could you create a pull-request on github?
> > > > Andrew, I wonder -- now all patch should go via PR?
> > > yes. This is the preferred way.
> > but emails must be acceptable still, right? I've no clue
> > how to make a pull request between different repositories
> > via github web interface.
> Hi Cyrill, you should be able to open a pull request with this link:
> 
> https://github.com/cyrillos/criu/compare/criu-dev...x86-xstate-fix
> 
> I have attached a screenshot with circles around base branch, fork-ed branch
> and the button that will open a pull request.

Done. https://github.com/cyrillos/criu/pull/21

Actually I don't understand how this supposed to work with checkpoint-restore/criu
repository. You guys gonna review it on my repo and the fetch into
checkpoint-restore?

As by experience from LKML we usually provide a branch to fetch but review
procedure comes via emails. I must confess I really dislike all this modern
review procedures via some vague web interface :)


More information about the CRIU mailing list