[CRIU] [PATCH 09/17] file: Implement fnext_task

[Eric W. Biederman]

Alexei Starovoitov <alexei.starovoitov at gmail.com> writes:

> On Wed, Aug 19, 2020 at 6:25 AM Eric W. Biederman <ebiederm at xmission.com> wrote:
>>
>> The bug in the existing code is that bpf_iter does get_file instead
>> of get_file_rcu.  Does anyone have any sense of how to add debugging
>> to get_file to notice when it is being called in the wrong context?
>
> That bug is already fixed in bpf tree.
> See commit cf28f3bbfca0 ("bpf: Use get_file_rcu() instead of
> get_file() for task_file iterator")

I wished you had based that change on -rc1 instead of some random
looking place in David's Millers net tree.

I am glad to see that our existing debug checks can catch that
kind of problem when the code is exercised enough.

I am going to pull this change into my tree on top of -rc1 so we won't
have unnecessary conflicts.  Hopefully this will show up in -rc2 so the
final version of this patchset can use an easily describable base.

Eric