[CRIU] [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct

Linus Torvalds torvalds at linux-foundation.org
Tue Aug 18 04:21:07 MSK 2020


On Mon, Aug 17, 2020 at 6:13 PM Eric W. Biederman <ebiederm at xmission.com> wrote:
>
> task_lock is needed to protect task->files.

Hah. Right you are. I found a few cases where we didn't do that, but I
hadn't noticed that they were all of the pattern

        struct task_struct *tsk = current;

so "tsk->files" was safe for that reason..

So never mind.

           Linus


More information about the CRIU mailing list