[CRIU] Restoring images with page-*.img anonymized

[Pavel Emelianov]

On 30.09.2019 19:26, Dmitry Safonov wrote:
> Hi guys,
> 
> On 9/30/19 5:08 PM, Harshavardhan Unnibhavi wrote:
> [moved reply from top-post]
>> On Mon, Sep 30, 2019 at 2:47 PM Pavel Emelianov <xemul at virtuozzo.com
>> <mailto:xemul at virtuozzo.com>> wrote:
>>
>>      On 27.09.2019 21:58, Harshavardhan Unnibhavi wrote:
>>      > So by using the second option(as suggested by Dmitry) the
>>      following information is obtained(which is also obtained during a
>>      normal restore):
>>      > (A)
>>      > vdso: Runtime vdso/vvar matches dumpee, remap inplace
>>      > vdso: Remap rt-vdso 0x2a000 -> 0x7ffca6198000
>>      > vdso: Remap rt-vvar 0x27000 -> 0x7ffca6195000
>>      > vdso: Using gettimeofday() on vdso at 0x7ffca6198d40
>>      >
>>      > Other information when restored normally like:
>>      > (B)
>>      > vdso: PT_LOAD p_vaddr: 0x0
>>      > vdso: DT_HASH: 0x120
>>      > vdso: DT_STRTAB: 0x298
>>      > vdso: DT_SYMTAB: 0x1a8
>>      > vdso: DT_STRSZ: 0x5e
>>      > vdso: DT_SYMENT: 0x18
>>      >    vdso: nbucket 0x3 nchain 0xa bucket 0x7ffca6198128 chain
>>      0x7ffca6198134
>>      > vdso: image [vdso] 0x7ffca6198000-0x7ffca619a000 [vvar]
>>      0x7ffca6195000-0x7ffca6198000
>>      > is not available.
>>      >
>>      > Is the information in (A) enough to decide that the restore
>>      process was successful?
>>
>>      I think yes. Let's try and see how it goes.
>>
>> Cool, I will implement this!
> 
> Note that the diff I've sent just makes vdso to pass.
> 
> I'm not carefully following anonymize patches, but it depends on your
> goal: basically, if you expect that someone could send you for debugging
> anonymized images when restore failed because of proxify_vdso(), than
> you might want to actually save vdso page in pages*.img.
> 
> Maybe you would like to move vdso page from pages*.img to vdso*.img or
> something like that.

For the 1st step we want to drop vdso and try to restore w/o it :)

> I don't mind either way, it's JFI.
> 
> Thanks,
>            Dmitry
>