[CRIU] [PATCH] arch/x86: push correct eip on the stack before lretq

Cyrill Gorcunov gorcunov at gmail.com
Tue Sep 10 17:14:45 MSK 2019


On Tue, Sep 10, 2019 at 06:50:58AM -0700, Andrei Vagin wrote:
> Right now we use pushq, but it pushes sign-extended value, so if the
> parasite code is placed higher that 2Gb, we will see something like
> this:
> 
>    0xf7efd5b0:	pushq  $0x23
>    0xf7efd5b2:	pushq  $0xfffffffff7efd5b9
> => 0xf7efd5b7:	lretq
> 
> Actually we want to push 0xf7efd5b9 instead of 0xfffffffff7efd5b9.
> 
> Fixes: #398
> 
> Cc: Dmitry Safonov <dima at arista.com>
> Cc: Cyrill Gorcunov <gorcunov at gmail.com>
> Signed-off-by: Andrei Vagin <avagin at gmail.com>
Reviewed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>


More information about the CRIU mailing list