[CRIU] [PATCH] early-log: Print warnings only if the buffer is full

Cyrill Gorcunov gorcunov at gmail.com
Tue Oct 1 09:51:10 MSK 2019


On Tue, Oct 01, 2019 at 12:29:14AM +0100, Dmitry Safonov wrote:
> I don't see many issues with early-log, so we probably don't
> need the warning when it was used. Note that after
> commit 74731d9 ("zdtm: make grep_errors also grep warnings")
> also warnings are grepped by zdtm.py (and I believe that was
> an improvement) which prints some bothering lines:
> 
> > =[log]=> dump/zdtm/static/inotify00/38/1/dump.log
> > ------------------------ grep Error ------------------------
> > (00.000000) Will allow link remaps on FS
> > (00.000034) Warn  (criu/log.c:203): The early log isn't empty
> > ------------------------ ERROR OVER ------------------------
> 
> Instead of decreasing loglevel of the message, improve it by
> reporting a real issue.
> 
> Cc: Adrian Reber <adrian at lisas.de>
> Cc: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
> Cc: Radostin Stoyanov <rstoyanov1 at gmail.com>
> Signed-off-by: Dmitry Safonov <dima at arista.com>
Acked-by: Cyrill Gorcunov <gorcunov at gmail.com>


More information about the CRIU mailing list