[CRIU] [PATCHv2 1/4] mount: Add error messages

[Radostin Stoyanov]

On 18/11/2019 10:30, Pavel Tikhomirov wrote:
> On 11/17/19 1:29 PM, Radostin Stoyanov wrote:
>> On 17/11/2019 09:37, Pavel Tikhomirov wrote:
>>> Haven't you lost the "Unable to remount" hunk from v1? And maybe you can
>>> write "v2:..." comments so it would be easier to understand what's
>>> changed.
>> I'm sorry for the confusion. The same line was also being changed in the
>> following patch, so I combined both changes into a single one (in the
>> next patch).
> Looks completely lost in v2:
>
> [snorch at snorch criu]$ git log -p
> criupatchwork/3860~4..criupatchwork/3860 | grep ns_open_mountpoint -A9
> @@ -1335,8 +1335,10 @@ int ns_open_mountpoint(void *arg)
>    	}
>
>    	/* Remount all mounts as private to disable propagation */
> -	if (mount("none", "/", NULL, MS_REC|MS_PRIVATE, NULL))
> +	if (mount("none", "/", NULL, MS_REC|MS_PRIVATE, NULL)) {
> +		pr_perror("Unable to remount");
>    		goto err;
> +	}
>
> [snorch at snorch criu]$ git log -p
> criupatchwork/3875~4..criupatchwork/3875 | grep ns_open_mountpoint -A9
> [snorch at snorch criu]$
You are right. Thank you for catching that.
I added this change in https://github.com/checkpoint-restore/criu/pull/856

Radostin