[CRIU] [PATCH] Jenkins Issue: Fix unknown shell warning in test jenkins directory
Andrei Vagin
avagin at gmail.com
Fri Mar 15 19:43:20 MSK 2019
I would sugest to rewrite the subject this way:
test/jenkins: Fix unknown shell warning in test
Could you describe with more details the issue what is fixed by this
patch?
And could you try to run checkbashisms for these scripts?
Thanks,
Andrei
On Sat, Mar 09, 2019 at 12:20:21AM +0530, Harshavardhan Unnibhavi wrote:
> Signed-off-by: Harshavardhan Unnibhavi <hvubfoss at gmail.com>
> ---
> test/jenkins/actions.sh | 1 +
> test/jenkins/crit.sh | 1 +
> test/jenkins/criu-btrfs.sh | 1 +
> test/jenkins/criu-by-id.sh | 1 +
> test/jenkins/criu-dedup.sh | 1 +
> test/jenkins/criu-dump.sh | 1 +
> test/jenkins/criu-fcg.sh | 1 +
> test/jenkins/criu-groups.sh | 1 +
> test/jenkins/criu-inhfd.sh | 1 +
> test/jenkins/criu-iter.sh | 1 +
> test/jenkins/criu-join-ns.sh | 1 +
> test/jenkins/criu-lazy-common.sh | 1 +
> test/jenkins/criu-lazy-migration.sh | 1 +
> test/jenkins/criu-lazy-pages.sh | 1 +
> test/jenkins/criu-lib.sh | 3 ++-
> test/jenkins/criu-other.sh | 1 +
> test/jenkins/criu-overlay.sh | 1 +
> test/jenkins/criu-pre-dump.sh | 1 +
> test/jenkins/criu-remote-lazy-pages.sh | 1 +
> test/jenkins/criu-sibling.sh | 1 +
> test/jenkins/criu-snap.sh | 1 +
> test/jenkins/criu-stop.sh | 1 +
> test/jenkins/criu-user.sh | 1 +
> test/jenkins/criu.sh | 1 +
> 24 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/test/jenkins/actions.sh b/test/jenkins/actions.sh
> index 80190450..f18db803 100755
> --- a/test/jenkins/actions.sh
> +++ b/test/jenkins/actions.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check how crit de/encodes images
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/crit.sh b/test/jenkins/crit.sh
> index fcf1c58d..e69b0222 100755
> --- a/test/jenkins/crit.sh
> +++ b/test/jenkins/crit.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check how crit de/encodes images
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-btrfs.sh b/test/jenkins/criu-btrfs.sh
> index e749ad90..6b1522ff 100644
> --- a/test/jenkins/criu-btrfs.sh
> +++ b/test/jenkins/criu-btrfs.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # This is a job which is executed on btrfs
>
> source `dirname $0`/criu-lib.sh &&
> diff --git a/test/jenkins/criu-by-id.sh b/test/jenkins/criu-by-id.sh
> index 2381e73f..b27dc4e7 100644
> --- a/test/jenkins/criu-by-id.sh
> +++ b/test/jenkins/criu-by-id.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> echo 950000 > /sys/fs/cgroup/cpu,cpuacct/system/cpu.rt_runtime_us
> echo 950000 > /sys/fs/cgroup/cpu,cpuacct/system/jenkins.service/cpu.rt_runtime_us
> git checkout -f ${TEST_COMMIT}
> diff --git a/test/jenkins/criu-dedup.sh b/test/jenkins/criu-dedup.sh
> index e75ef5f8..277f75af 100755
> --- a/test/jenkins/criu-dedup.sh
> +++ b/test/jenkins/criu-dedup.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check auto-deduplication of pagemaps
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-dump.sh b/test/jenkins/criu-dump.sh
> index 381cf7a9..38519aa7 100755
> --- a/test/jenkins/criu-dump.sh
> +++ b/test/jenkins/criu-dump.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check that dump is not destructive
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-fcg.sh b/test/jenkins/criu-fcg.sh
> index 938a72f2..59cfd51e 100755
> --- a/test/jenkins/criu-fcg.sh
> +++ b/test/jenkins/criu-fcg.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Test how freeze cgroup works
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-groups.sh b/test/jenkins/criu-groups.sh
> index 508d20aa..69efd2e4 100755
> --- a/test/jenkins/criu-groups.sh
> +++ b/test/jenkins/criu-groups.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make one regular C/R cycle over randomly-generated groups
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-inhfd.sh b/test/jenkins/criu-inhfd.sh
> index a59dcda6..5d1531cc 100755
> --- a/test/jenkins/criu-inhfd.sh
> +++ b/test/jenkins/criu-inhfd.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check known fault injections
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-iter.sh b/test/jenkins/criu-iter.sh
> index d414b057..7ff2909f 100755
> --- a/test/jenkins/criu-iter.sh
> +++ b/test/jenkins/criu-iter.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make 3 iteration of dump/restore for each test
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-join-ns.sh b/test/jenkins/criu-join-ns.sh
> index 39ef182f..9e45fdd1 100755
> --- a/test/jenkins/criu-join-ns.sh
> +++ b/test/jenkins/criu-join-ns.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make one regular C/R cycle
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-lazy-common.sh b/test/jenkins/criu-lazy-common.sh
> index 7fdab40d..dcad2112 100644
> --- a/test/jenkins/criu-lazy-common.sh
> +++ b/test/jenkins/criu-lazy-common.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> KERN_MAJ=`uname -r | cut -d. -f1`
> KERN_MIN=`uname -r | cut -d. -f2`
> if [ $KERN_MAJ -ge "4" ] && [ $KERN_MIN -ge "11" ]; then
> diff --git a/test/jenkins/criu-lazy-migration.sh b/test/jenkins/criu-lazy-migration.sh
> index 30e3c037..091f5d62 100755
> --- a/test/jenkins/criu-lazy-migration.sh
> +++ b/test/jenkins/criu-lazy-migration.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check lazy-pages
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-lazy-pages.sh b/test/jenkins/criu-lazy-pages.sh
> index a3ee9a4e..41d03e47 100755
> --- a/test/jenkins/criu-lazy-pages.sh
> +++ b/test/jenkins/criu-lazy-pages.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check lazy-pages
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-lib.sh b/test/jenkins/criu-lib.sh
> index 72d41b57..b43a6c5e 100644
> --- a/test/jenkins/criu-lib.sh
> +++ b/test/jenkins/criu-lib.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> function exit_hook()
> {
> test -z "$GCOV" && return
> @@ -25,7 +26,7 @@ function prep()
>
> function mount_tmpfs_to_dump()
> {
> - test -n "$SKIP_PREP" && return
> + test -n "$SKIP_PREP" && return
> mkdir -p test/dump &&
> mount -t tmpfs criu_dump test/dump &&
> true
> diff --git a/test/jenkins/criu-other.sh b/test/jenkins/criu-other.sh
> index c6c231c8..9af2a315 100755
> --- a/test/jenkins/criu-other.sh
> +++ b/test/jenkins/criu-other.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> source `dirname $0`/criu-lib.sh &&
> prep &&
> make -C test other &&
> diff --git a/test/jenkins/criu-overlay.sh b/test/jenkins/criu-overlay.sh
> index 5ef7682a..8140a7c9 100755
> --- a/test/jenkins/criu-overlay.sh
> +++ b/test/jenkins/criu-overlay.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make one regular C/R cycle
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-pre-dump.sh b/test/jenkins/criu-pre-dump.sh
> index 95f4d854..26831756 100755
> --- a/test/jenkins/criu-pre-dump.sh
> +++ b/test/jenkins/criu-pre-dump.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check 3 pre-dump-s before dump (with and w/o page server)
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-remote-lazy-pages.sh b/test/jenkins/criu-remote-lazy-pages.sh
> index ea0d17f0..537c76bb 100755
> --- a/test/jenkins/criu-remote-lazy-pages.sh
> +++ b/test/jenkins/criu-remote-lazy-pages.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check remote-lazy-pages
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-sibling.sh b/test/jenkins/criu-sibling.sh
> index 93f07033..56648e7c 100755
> --- a/test/jenkins/criu-sibling.sh
> +++ b/test/jenkins/criu-sibling.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make 3 iteration of dump/restore for each test
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-snap.sh b/test/jenkins/criu-snap.sh
> index d28ba45d..a05663ee 100755
> --- a/test/jenkins/criu-snap.sh
> +++ b/test/jenkins/criu-snap.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check snapshots
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-stop.sh b/test/jenkins/criu-stop.sh
> index d92519d6..f4ec528c 100644
> --- a/test/jenkins/criu-stop.sh
> +++ b/test/jenkins/criu-stop.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Check --leave-stopped option
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu-user.sh b/test/jenkins/criu-user.sh
> index d89ede20..bca61c0f 100755
> --- a/test/jenkins/criu-user.sh
> +++ b/test/jenkins/criu-user.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make 3 iteration of dump/restore for each test
> set -e
> source `dirname $0`/criu-lib.sh
> diff --git a/test/jenkins/criu.sh b/test/jenkins/criu.sh
> index 19d545c3..804c83f2 100755
> --- a/test/jenkins/criu.sh
> +++ b/test/jenkins/criu.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Make one regular C/R cycle
> set -e
> source `dirname $0`/criu-lib.sh
> --
> 2.17.1
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
More information about the CRIU
mailing list