[CRIU] [PATCH] tty: Make params setup synchronous

Cyrill Gorcunov gorcunov at gmail.com
Tue Mar 12 21:55:13 MSK 2019


It was never designed to run params in ansync mode,
and i always been against this change because async
here is too fragile.

p.s.:

I think this might be a reason for

https://github.com/checkpoint-restore/criu/issues/647

Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
---
 criu/tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/criu/tty.c b/criu/tty.c
index ad957485829a..6fe11530a73c 100644
--- a/criu/tty.c
+++ b/criu/tty.c
@@ -894,7 +894,7 @@ static int restore_tty_params(int fd, struct tty_info *info)
 		}
 	}
 
-	return userns_call(do_restore_tty_parms, UNS_ASYNC, &p, sizeof(p), fd);
+	return userns_call(do_restore_tty_parms, 0, &p, sizeof(p), fd);
 }
 
 /*
-- 
2.20.1



More information about the CRIU mailing list