[CRIU] [PATCH 3/3] Issue #360: Anonymize image files

Radostin Stoyanov rstoyanov1 at gmail.com
Tue Jun 25 13:33:10 MSK 2019


On 25/06/2019 10:52, Pavel Emelianov wrote:
>>>> diff --git a/lib/py/strip.py b/lib/py/strip.py
>>>> new file mode 100644
>>>> index 00000000..4069275c
>>>> --- /dev/null
>>>> +++ b/lib/py/strip.py
>> The indentation of this file is using spaces, (IMHO we should be using
>> space for python code) however, the rest of the code base is using tabs.
>> For consistency it might be better to use tabs in this file as well?
> I've been told a lot that true pythonic indentation is with spaces, not tabs.
> That said -- should we take sed and re-format the whole py stuff into spaces?
https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

I think we should. Then we can drop W191 and E101 from the ignore list 
in scripts/flake8.cfg

Radostin


More information about the CRIU mailing list