[CRIU] [PATCH 00/16] mem: Cleanup and fixups

Andrey Vagin avagin at gmail.com
Mon Jul 8 07:06:12 MSK 2019


Abhishek, could you review this series?

On Fri, Jul 05, 2019 at 06:37:55PM +0300, Cyrill Gorcunov wrote:
> I'm hunting a subtle bug in iterative memory migration which
> forced me to make a deep memory subsystem code review, so
> while work is not yet complete by now I still think it would
> be worth to send series as soon as possible for review sake.
> 
> Nothing much changed I think except patches:
>  - mem/page-pipe: Use ssize_t for splice/tee results
>  - mem/shmem: Use xmalloc in collect_sysv_shmem
>  - mem/shmem: Fix typos for_each_shmem macro
> 
> which do really fix a few errors.
> 
> Cyrill Gorcunov (16):
>   mem/page-pipe: Eliminate redundant pipe_off setup
>   mem/page-pipe: create_page_pipe -- Drop redundant zero assignment
>   mem/page-pipe: Align members for readability sake
>   mem/page-pipe: Use ssize_t for splice/tee results
>   mem/vma: Use memset for vm_area_list_init
>   mem/vma: Use vm_area_list_init where appropriate
>   mem/vma: Drop never used VM_AREA_LIST macro
>   mem/vma: Sanitize struct vm_area_list
>   mem/page-xfer: Add log prefix
>   mem/pmc: Use pr_warn_once if cache is disabled
>   mem/pmc: Print pid for debug sake
>   mem/page-pipe: Use xrealloc_safe in page_pipe_add_hole
>   mem/shmem: Use xrealloc_safe in expand_shmem
>   mem/shmem: Reorder code in expand_shmem
>   mem/shmem: Use xmalloc in collect_sysv_shmem
>   mem/shmem: Fix typos for_each_shmem macro
> 
>  criu/cr-dump.c           | 11 ++++------
>  criu/include/page-pipe.h | 46 ++++++++++++++++++++--------------------
>  criu/include/vma.h       | 23 ++++++++++----------
>  criu/mem.c               | 20 ++++++++---------
>  criu/page-pipe.c         | 33 ++++++++++------------------
>  criu/page-xfer.c         |  3 +++
>  criu/pagemap-cache.c     | 18 ++++++++--------
>  criu/proc_parse.c        | 16 ++++++--------
>  criu/shmem.c             | 18 ++++++++--------
>  9 files changed, 86 insertions(+), 102 deletions(-)
> 
> -- 
> 2.20.1
> 


More information about the CRIU mailing list