[CRIU] [PATCH 3/3] tty: Goto err when fail to unlock master pty

Cyrill Gorcunov gorcunov at gmail.com
Thu Jan 17 12:03:22 MSK 2019


On Tue, Jan 15, 2019 at 09:43:14AM -0800, Andrei Vagin wrote:
> > Because pty pair is created in locked state, on which you can't
> > do anything, iow it is a first stage of pty restore. Later we
> > setup various parameters on the peer, thus we need to unlock
> > it first. In case if this action failed we will exit with error
> > anytway. The whole series is about code simplification and
> > shrinking.
> 
> I still don't understand why we should not handle this error...
> 
> "code simplification and shrinking" doesn't mean that we don't want to
> handle errors...

Well, if you still prefer to handle it explicitly then I think
we should simply drop this patch and leave the code as is.


More information about the CRIU mailing list