[CRIU] [PATCH v5 2/3] Do not error out in RPC mode with wrong config file entries

[Radostin Stoyanov]

On 02/01/2019 17:36, Adrian Reber wrote:
>>>> Yes and no. I understand the sshd reasons, but they can be applied to
>>>> criu restore, but not to criu dump, IMHO.
>>>>
>>>> Our goal is to not loose states of processes:
>>>> 1. criu dump doesn't have to be destructive:
>>>>   * in case of any error, processes have to continue running
>>>>   * it is better to fail rather than dump wrong or incomplete state
>>>>
>>>> 2. sometimes we really may want to restore processes even if there is
>>>> some problem
>>> That is a very good point, I agree with you.
>>>
>>> Is it OK to close https://github.com/checkpoint-restore/criu/issues/578
>>> with the explanation above?
>> I would like to know what Adrian is thinking about this.
> The whole series was just trying to help with Radostin's 'bug'. But if
> nobody sees this as a problem we can drop the whole thing.
>
I understand that we want criu to exit with an error when we have
unknown options in config files, thus we can drop PATCH v5 2/3 and 3/3.

However, I think that PATCH v5 1/3 (Printout early log messages) is useful.
Is there a reason why we don't want this patch?

Radostin