[CRIU] [PATCH 5/5] test: Add unlink_dir test

Cyrill Gorcunov gorcunov at gmail.com
Thu Feb 28 10:50:14 MSK 2019


On Thu, Feb 28, 2019 at 07:34:58AM +0000, Pavel Tikhomirov wrote:
> > 
> > We *already* do, from the beginning of ghost directories support,
> > and to address this problem we need a significant rework of file
> > engine (in particular we need to remember paths collected and
> > find if some of ghost entries are intersected with alive ones).
> > I'm planning to address it once time permit. Meanwhile I sent
> > another light series where we only order ghost entries which
> > doesn't change anything but simply fix easy case.
> > 
> 
> AFAICS We just need to fix mkdirpat_precise in v6. Just make it fail in 
> errno == EEXIST branch if pos == NULL. These way mkdirpat will fail if 
> alive directory exists in place of on our deleted directory at leas on 
> restore.

What we need is to detect such collision on _dump_ not on restore :(


More information about the CRIU mailing list