[CRIU] [PATCH 5/5] test: Add unlink_dir test

[Cyrill Gorcunov]

On Wed, Feb 27, 2019 at 10:48:29PM -0800, Andrei Vagin wrote:
> On Wed, Feb 27, 2019 at 12:58 AM Cyrill Gorcunov <gorcunov at gmail.com> wrote:
> >
> > On Tue, Feb 26, 2019 at 10:51:32PM -0800, Andrei Vagin wrote:
> > > Hi Cyrill,
> > >
> > > Looks at this patch. The test passes without C/R and fails with C/R.
> >
> > You know, it is a different issue -- the ghost directory intersects
> > with alive one. We never supported such things. But think we should
> > add a support.
> 
> If we don't support such things, criu dump has to fail. Now we corrupt
> a user file system in this case, what is unacceptable...

We *already* do, from the beginning of ghost directories support,
and to address this problem we need a significant rework of file
engine (in particular we need to remember paths collected and
find if some of ghost entries are intersected with alive ones).
I'm planning to address it once time permit. Meanwhile I sent
another light series where we only order ghost entries which
doesn't change anything but simply fix easy case.