[CRIU] [PATCH 4/5] files: Cleanup ghost subdirectories

Cyrill Gorcunov gorcunov at gmail.com
Wed Feb 27 11:34:33 MSK 2019


On Wed, Feb 27, 2019 at 09:59:32AM +0300, Cyrill Gorcunov wrote:
> On Tue, Feb 26, 2019 at 10:49:18PM -0800, Andrei Vagin wrote:
> ...
> > > -	return 0;
> > > +	if (ret) {
> > > +		if (errno == ENOENT)
> > > +			ret = 0;
> > > +	} else
> > > +		ret = cleanup_subdir(rmntns_root, remap);
> > 
> > should we call cleanup_subdir() if errno == ENOENT?
> Nope :) If errno == enoent it means there is notthing to clean :)
> But I think I got what is confusing you. We should call
> subdirs cleanup only on enotempty. Will update, thanks!

Well, not really. We need to clean up all transient entries
once we cleaned up the lower dentry. I simply put more
detailed comment here.

	Cyrill


More information about the CRIU mailing list