[CRIU] [PATCH 3/5] files: Rework clean_one_remap to order ghost dirs removal

Cyrill Gorcunov gorcunov at gmail.com
Tue Feb 26 16:16:54 MSK 2019


On Tue, Feb 26, 2019 at 01:09:15PM +0000, Pavel Tikhomirov wrote:
> > +	if (ret) {
> > +		pr_perror("Couldn't unlink remap %d %s", rmntns_root, remap->rpath);
> >   		close(rmntns_root);
> > -		pr_perror("Couldn't unlink remap %s %s", path, remap->rpath);
> 
> Missed these previously, why you change path to rmntns_root? Please see 
> commit caaedad3f ("files-reg: make error message in clean_one_remap 
> contain mntns path")

Because I start working with this set on criu-stable when we had
no such commit, and cherry-picked it here. Good point, I'll send
a fix on top.


More information about the CRIU mailing list