[CRIU] [PATCH 1/2] test: Add unlink_dir test

Cyrill Gorcunov gorcunov at gmail.com
Fri Feb 8 15:08:43 MSK 2019


On Fri, Feb 08, 2019 at 01:24:27PM +0300, Pavel Tikhomirov wrote:
>      >    check error like: if (len >= sizeof(path_dir1)) return -1;
> 
>      It is for warnings suppression nothing else. Strictly speaking we might
>      need to check for negative value rather but since it is path-max limit
>      i don't expect here any errors at all, just to placate gcc.
> 
>    FMPOV actual overflow check is better here, it is what gcc really wants
>    from us by these warnings.
>    Except that, Reviewed-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

I don't mind. Will update.


More information about the CRIU mailing list