[CRIU] [PATCH 05/32] timerfd/timens: Take into account ns clock offsets

Cyrill Gorcunov gorcunov at gmail.com
Wed Feb 6 11:55:25 MSK 2019


On Wed, Feb 06, 2019 at 11:52:03AM +0300, Cyrill Gorcunov wrote:
...
> >  
> > -	if ((flags & ~TFD_SETTIME_FLAGS) ||
> > -		 !itimerspec64_valid(new))
> > -		return -EINVAL;
> 
> Please don't defer this early test of a @flags value. Otherwise
> if @flags is invalid you continue fget/put/clock-to-host even
> if result will be dropped out then.

Just to clarify -- this could be done on top of the series to
not resend the whole bunch.


More information about the CRIU mailing list