[CRIU] github pull-requests

Radostin Stoyanov rstoyanov1 at gmail.com
Sat Feb 2 14:20:45 MSK 2019


On 01/02/2019 17:45, Andrei Vagin wrote:
> Hi All,
>
>
> Let's start this experiment. Starting from today, you can create
> pull-requests on github. And it is a preferred way to submit changes.
Should we update https://criu.org/How_to_submit_patches and README.md?

Add Travis CI Bot on the github repository?

Do we still need 5, 6 and 7 from the list below?

Radostin
> On Tue, Nov 20, 2018 at 12:22:21AM -0800, Andrei Vagin wrote:
>> Hello,
>>
>> On the Linux Plumbers Conference, I heard a few requests to start
>> accepting github pull-requests. Then we discussed this on the first
>> official criu hackathon and it looks like there were no objections. I
>> know that many of you were not able to be there, so I decided to start
>> this thread where you can share thoughts about the subject.
>>
>> Pros:
>> * It is easier to create a pull-requests than send a patch. Stop,
>> stop, stop. Don't laugh. You did this many times, but for a new
>> contributor, it is a real problem.
>> * We can remove all our machinery, what is used validate patches.
>>
>> Cons:
>> * The standard workflow is changed for people who read patches in the
>> mailing list.
>> * No multi-thread discussions
>>
>> https://begriffs.com/posts/2018-06-05-mailing-list-vs-github.html
>>
>> Questions:
>> 1. Should we start accepting github pull requests?
>> 2. Should we stop accepting patches from a mailing list?
>> 3. Can we do both?
>> 4. Which path should be a preferred one?
>> 5. Do we need a robot which will send github pull-requests into the
>> mailing list?
>> https://github.com/google/pull-request-mailer
>> 6. Do we need a robot which will create github pull-requests from patch series?
>> 7. Should we sync comments between the mailing list and github?
>> 8. Who wants to implement 5., 6. and 7.?
>>
>> My answers:
>> 1. yes
>> 2. no
>> 3. yes
>> 4. the mailing list
>> 5. yes
>> 6. would be good
>> 7. would be good
>> 8. I don't :)
>>
>> Thanks,
>> Andrei Vagin
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu



More information about the CRIU mailing list