[CRIU] [vdso] New vdso series failing the tests

Dmitry Safonov 0x7f454c46 at gmail.com
Sat Aug 10 04:44:54 MSK 2019


On 8/8/19 3:28 PM, Dmitry Safonov wrote:
> Hi Cyrill,
> 
> On 8/8/19 2:52 PM, Cyrill Gorcunov wrote:
>> Dima, the recent series for vdso rework ruined tests on old
>> kernels, such as 3.10 series.
>>
>> https://ci.openvz.org/job/CRIU/job/CRIU-virtuozzo/job/criu-dev/5398/
>>
>> ---
>> [root at vz7 criu]# git bisect good
>> 0918c7667647ac16d6082764f78d1c0b407f3536 is the first bad commit
>> commit 0918c7667647ac16d6082764f78d1c0b407f3536
>> Author: Dmitry Safonov <dima at arista.com>
>> Date:   Thu Jul 25 23:01:10 2019 +0100
>>
>>     vdso/restorer: Always track vdso/vvar positions in vdso_maps_rt
>>     
>>     For simplicity, make them always valid in restorer.
>>     rt->vdso_start will be used to calculate gettimeofday() address.
>>     
>>     Signed-off-by: Dmitry Safonov <dima at arista.com>
>>     Signed-off-by: Andrei Vagin <avagin at gmail.com>
>> ---
>>
>> I think it is due to lack of vvar zone on those kernels. Please take a look.
> 
> I'll look, thanks for notice..
> 

[offtop]: there is a slight chance that you may be interested in testing
criu on vzkernel in VM without bothering much to install modules and all
that jazz:
https://gist.github.com/0x7f454c46/48cc81a0ddebaab3743d7e6d1ddf597b
(though, I've turned off some more config options to make it compile, so
it may need some more polishing if bpf stuff is needed)

-- 
          Dima


More information about the CRIU mailing list