[CRIU] [V3 0/4] help to review patches for build with Android NDK

Andrei Vagin avagin at gmail.com
Mon Apr 8 21:11:29 MSK 2019


On Sun, Apr 7, 2019 at 6:22 PM Zhang, Ning A <ning.a.zhang at intel.com> wrote:
>
> Hi,
>
> Thanks for merge my patches, but this V3 patches are partial update for
> V2. it only updates patch 5 of V2 patches set.
>
> How about rest 5 patches in patches set V2? do I need to send V4?

Pls send v4. It will be easier. Thanks!

>
> V2 patches set: https://lists.openvz.org/pipermail/criu/2019-April/0436
> 97.html
> unmerged patches from V2:
> https://lists.openvz.org/pipermail/criu/2019-April/043698.html
> https://lists.openvz.org/pipermail/criu/2019-April/043699.html
> https://lists.openvz.org/pipermail/criu/2019-April/043701.html
> https://lists.openvz.org/pipermail/criu/2019-April/043700.html
> https://lists.openvz.org/pipermail/criu/2019-April/043702.html
>
> BR.
> Ning.
>
>
> 在 2019-04-04四的 22:50 -0700,Andrei Vagin写道:
> > Applied, thanks!
> >
> > On Thu, Apr 04, 2019 at 10:22:28AM +0800, ning.a.zhang at intel.com
> > wrote:
> > > From: Zhang Ning <ning.a.zhang at intel.com>
> > >
> > > Hi, all
> > >
> > > Previous patches I added -Wno-macro-redefined and -Wno-implicit-
> > > function-declaration,
> > > in CRIU Makefile or build script to supress error reported by
> > > Android NDK/Clang.
> > > this is wrong, pointed out by Dmitry, Thank you.
> > >
> > > Thus two new patches are added.
> > >
> > > Change log:
> > > remove -Wno-implicit-function-declaration.
> > > add ifndef check for UNIX_PATH_MAX to avoid -Wno-macro-redefined.
> > > add index function declare.
> > > add notes for Android NDK cross compile.
> > >
> > > Zhang Ning (4):
> > >   Android NDK: necessary Makefile changes
> > >   Android NDK: UNIX_PATH_MAX is defined in un.h
> > >   Android NDK: no index function in strings.h
> > >   Add notes for Android NDK cross compile
> > >
> > >  Documentation/HOWTO.cross-compile | 8 ++++++++
> > >  compel/src/lib/infect.c           | 2 ++
> > >  criu/Makefile                     | 2 +-
> > >  criu/Makefile.packages            | 2 +-
> > >  criu/config.c                     | 2 ++
> > >  criu/include/util-pie.h           | 2 ++
> > >  6 files changed, 16 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.20.1
> > >
> > > _______________________________________________
> > > CRIU mailing list
> > > CRIU at openvz.org
> > > https://lists.openvz.org/mailman/listinfo/criu
> >



More information about the CRIU mailing list