[CRIU] [PATCH 2/2] change Makefile in order to pass build under Android NDK

[Dmitry Safonov]

On 4/1/19 7:39 PM, Dmitry Safonov wrote:
> Hi Zhang,
> 
> On 4/1/19 4:18 AM, ning.a.zhang at intel.com wrote:
>> From: Zhang Ning <ning.a.zhang at intel.com>
>>
>> 1, disable some warning
>> 2, do not hardcode libnl's cflags
>> 3, remove link to rt
>>
>> Cc: Chen Hu <hu1.chen at intel.com>
>> Signed-off-by: Zhang Ning <ning.a.zhang at intel.com>
>> ---
>>  Makefile               | 2 +-
>>  criu/Makefile          | 2 +-
>>  criu/Makefile.packages | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 38887da9..2ee46e3a 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -89,7 +89,7 @@ export PROTOUFIX DEFINES
>>  DEFINES			+= -D_FILE_OFFSET_BITS=64
>>  DEFINES			+= -D_GNU_SOURCE
>>  
>> -WARNINGS		:= -Wall -Wformat-security
>> +WARNINGS		:= -Wall -Wformat-security -Wno-implicit-function-declaration -Wno-macro-redefined
> 
> Looking at man(gcc):
> : -Wimplicit-function-declaration (C and Objective-C only)
> :      Give a warning whenever a function is used before being declared.
> 
> I wonder if we have those hits.. Do you observe many of them?
> I believe they are against code style (imho), could we rather fix them
> (if the amount is not hundreds)?
> 
> And for "-Wno-macro-redefined" - it seems to be clang-specific flag..
> Could you tell why it's needed? (IOW, what does it fix?)
> Have you checked that compilation is giving you more warnings with gcc?


> On my machine compiling random source with the flag gives me:
> : At global scope:
> : cc1plus: warning: unrecognized command line option ‘-Wno-macro-redefined

Actually, I mistakenly did gcc over .cpp file and it's used g++.
For .c it ignores the option.
But details why the option added - are needed to justify the patch.

Thanks,
          Dmitry