[CRIU] [PATCH 11/19] unix: test -- Add bind-mount-unix test case

Cyrill Gorcunov gorcunov at gmail.com
Fri Sep 14 17:08:34 MSK 2018


From: Cyrill Gorcunov <gorcunov at openvz.org>

To test a case where unix socket is bind mounted to somewhere
so restore may fail if socket has not been created.

Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 test/zdtm/static/Makefile             |   1 +
 test/zdtm/static/bind-mount-unix.c    | 139 ++++++++++++++++++++++++++
 test/zdtm/static/bind-mount-unix.desc |   1 +
 3 files changed, 141 insertions(+)
 create mode 100644 test/zdtm/static/bind-mount-unix.c
 create mode 100644 test/zdtm/static/bind-mount-unix.desc

diff --git a/test/zdtm/static/Makefile b/test/zdtm/static/Makefile
index fe67747db954..7ea97aaa9373 100644
--- a/test/zdtm/static/Makefile
+++ b/test/zdtm/static/Makefile
@@ -336,6 +336,7 @@ TST_DIR		=				\
 		del_standalone_un		\
 		sk-unix-mntns			\
 		sk-unix01			\
+		bind-mount-unix			\
 		unsupported_children_collision  \
 		shared_slave_mount_children	\
 		non_uniform_share_propagation	\
diff --git a/test/zdtm/static/bind-mount-unix.c b/test/zdtm/static/bind-mount-unix.c
new file mode 100644
index 000000000000..2981c408a1da
--- /dev/null
+++ b/test/zdtm/static/bind-mount-unix.c
@@ -0,0 +1,139 @@
+#include <stdbool.h>
+#include <string.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <sys/mount.h>
+#include <sys/stat.h>
+#include <sys/socket.h>
+#include <sys/wait.h>
+#include <sys/un.h>
+#include <linux/limits.h>
+
+#include "zdtmtst.h"
+
+const char *test_doc	= "Check bind-mounts with unix socket";
+const char *test_author	= "Cyrill Gorcunov <gorcunov at virtuozzo.com>";
+
+char *dirname;
+TEST_OPTION(dirname, string, "directory name", 1);
+
+int main(int argc, char **argv)
+{
+	char path_unix[PATH_MAX], path_bind[PATH_MAX];
+	char unix_name[] = "criu-log";
+	char bind_name[] = "criu-bind-log";
+	int sk = -1, skc = -1, ret = 1, fd;
+	struct sockaddr_un addr;
+	unsigned int addrlen;
+	struct stat st;
+
+	char buf[] = "123456";
+	char rbuf[sizeof(buf)];
+
+	test_init(argc, argv);
+
+	mkdir(dirname, 0700);
+	if (mount("none", dirname, "tmpfs", 0, NULL)) {
+		pr_perror("Unable to mount %s", dirname);
+		return 1;
+	}
+
+	ssprintf(path_bind, "%s/%s", dirname, bind_name);
+	ssprintf(path_unix, "%s/%s", dirname, unix_name);
+
+	unlink(path_bind);
+	unlink(path_unix);
+
+	fd = open(path_bind, O_RDONLY | O_CREAT);
+	if (fd < 0) {
+		pr_perror("Can't open %s", path_bind);
+		goto err;
+	}
+	close(fd);
+
+	addr.sun_family = AF_UNIX;
+	sstrncpy(addr.sun_path, path_unix);
+	addrlen = sizeof(addr.sun_family) + strlen(path_unix);
+
+	sk = socket(AF_UNIX, SOCK_DGRAM, 0);
+	if (sk < 0) {
+		pr_perror("Can't create socket %s", path_unix);
+		goto err;
+	}
+
+	ret = bind(sk, (struct sockaddr *)&addr, addrlen);
+	if (ret) {
+		pr_perror("Can't bind socket %s", path_unix);
+		goto err;
+	}
+
+	if (stat(path_unix, &st) == 0) {
+		test_msg("path %s st.st_ino %#lx st.st_mode 0%o (sock %d)\n",
+			 path_unix, (unsigned long)st.st_ino,
+			 (int)st.st_mode, !!S_ISSOCK(st.st_mode));
+	} else
+		pr_perror("Can't stat on %s", path_unix);
+
+	if (mount(path_unix, path_bind, NULL, MS_BIND | MS_REC, NULL)) {
+		pr_perror("Unable to bindmount %s -> %s", path_unix, path_bind);
+		goto err;
+	}
+
+	if (stat(path_unix, &st) == 0) {
+		test_msg("path %s st.st_dev %#x st.st_rdev %#x st.st_ino %#lx st.st_mode 0%o (sock %d)\n",
+			 path_unix, (int)st.st_dev, (int)st.st_rdev, (unsigned long)st.st_ino,
+			 (int)st.st_mode, !!S_ISSOCK(st.st_mode));
+	} else
+		pr_perror("Can't stat on %s", path_unix);
+
+	if (stat(path_bind, &st) == 0) {
+		test_msg("path %s st.st_dev %#x st.st_rdev %#x st.st_ino %#lx st.st_mode 0%o (sock %d)\n",
+			 path_bind, (int)st.st_dev, (int)st.st_rdev, (unsigned long)st.st_ino,
+			 (int)st.st_mode, !!S_ISSOCK(st.st_mode));
+	} else
+		pr_perror("Can't stat on %s", path_bind);
+
+	test_daemon();
+	test_waitsig();
+
+	skc = socket(AF_UNIX, SOCK_DGRAM, 0);
+	if (skc < 0) {
+		pr_perror("Can't create client socket");
+		goto err;
+	}
+
+	addr.sun_family = AF_UNIX;
+	sstrncpy(addr.sun_path, path_bind);
+	addrlen = sizeof(addr.sun_family) + strlen(path_bind);
+
+	ret = sendto(skc, buf, sizeof(buf), 0, (struct sockaddr *)&addr, addrlen);
+	if (ret != (int)sizeof(buf)) {
+		pr_perror("Can't send data on client");
+		ret = 1;
+		goto err;
+	}
+
+	ret = read(sk, rbuf, sizeof(rbuf));
+	if (ret < 0) {
+		pr_perror("Can't read data");
+		ret = 1;
+		goto err;
+	}
+
+	if (ret != sizeof(buf) || memcmp(buf, rbuf, sizeof(buf))) {
+		pr_err("Data mismatch");
+		ret = 1;
+		goto err;
+	}
+
+	pass();
+	ret = 0;
+
+err:
+	umount2(path_bind, MNT_DETACH);
+	umount2(dirname, MNT_DETACH);
+	unlink(path_bind);
+	unlink(path_unix);
+	close(sk);
+	return ret;
+}
diff --git a/test/zdtm/static/bind-mount-unix.desc b/test/zdtm/static/bind-mount-unix.desc
new file mode 100644
index 000000000000..a8849e09708b
--- /dev/null
+++ b/test/zdtm/static/bind-mount-unix.desc
@@ -0,0 +1 @@
+{'flavor': 'ns uns', 'flags': 'suid', 'feature': 'mnt_id'}
-- 
2.17.1



More information about the CRIU mailing list