[CRIU] [PATCH 0/5] criu: remove all magic of service-fd when it isn't required

Kirill Tkhai ktkhai at virtuozzo.com
Fri Sep 14 10:09:11 MSK 2018


On 13.09.2018 2:41, Andrei Vagin wrote:
> Service descriptors are a set of file descriptors which isn't
> intercepted with restored file descriptors.
> 
> In all cases, when we don't need to restore file descriptors, we can
> skip all magic of service-fd and just save descriptor numbers in a
> static array.
> 
> Andrei Vagin (5):
>   service-fd: close a source file descriptor in install_service_fd()
>   check: don't close file descriptors in check_user_ns
>   criu: remove all magic of service-fd when it isn't required
>   criu: set RLIMIT_NOFILE to maximum only on restore
>   criu: call kerndat_init() after log_init()
> 
>  criu/action-scripts.c |  2 +-
>  criu/cgroup.c         |  1 -
>  criu/cr-dump.c        |  2 --
>  criu/cr-restore.c     | 33 ++++++++++++++++++++++++++++++++-
>  criu/cr-service.c     |  3 +++
>  criu/crtools.c        | 38 +++-----------------------------------
>  criu/fdstore.c        |  1 -
>  criu/files.c          |  8 +++-----
>  criu/image.c          |  3 ++-
>  criu/log.c            |  1 -
>  criu/mount.c          |  1 -
>  criu/namespaces.c     |  7 -------
>  criu/net.c            |  1 -
>  criu/util.c           | 18 +++++++++++++-----
>  14 files changed, 57 insertions(+), 62 deletions(-)

Looks good for me.

Reviewed-by: Kirill Tkhai <ktkhai at virtuozzo.com>


More information about the CRIU mailing list