[CRIU] [PATCH 0/3] ia32/x86-compat: Kill call32_from_64 with fire!

Dmitry Safonov dima at arista.com
Wed Oct 31 01:35:28 MSK 2018


It seems that call32_from_64() can be used only if it's code is under
4Gb address. It's not guaranteed that .code32 will be mapped within
32-bit space.

And it seems to me that after criu patches were mainstreamed, it's
possible to do int80 instead of full switch to ia32 mode.

Probably, it's never late to cleanup it up.

Dmitry Safonov (3):
  restorer: Remember to check ret codes for syscalls
  x86/compat: Use do_full_int80() instead of jump to ia32 mode
  x86/compat: Remove call32_from_64() helper

 criu/arch/x86/Makefile             |  1 -
 criu/arch/x86/call32.S             | 76 ------------------------------
 criu/arch/x86/include/asm/compat.h |  5 --
 criu/arch/x86/sigaction_compat.c   | 18 +++++--
 criu/pie/Makefile                  |  1 -
 criu/pie/restorer.c                | 18 +++++--
 6 files changed, 29 insertions(+), 90 deletions(-)
 delete mode 100644 criu/arch/x86/call32.S

-- 
2.19.1



More information about the CRIU mailing list