[CRIU] [PATCH 2/2] net: sockets -- Don't spam log with known errors

[Cyrill Gorcunov]

On Tue, Oct 09, 2018 at 11:26:24PM -0700, Andrey Vagin wrote:
> > diff --git a/criu/include/libnetlink.h b/criu/include/libnetlink.h
> > index bf2eb24740b0..f21a0e750337 100644
> > --- a/criu/include/libnetlink.h
> > +++ b/criu/include/libnetlink.h
> > @@ -6,7 +6,7 @@
> >  struct ns_id;
> >  extern int do_rtnl_req(int nl, void *req, int size,
> >  		int (*receive_callback)(struct nlmsghdr *h, struct ns_id *ns, void *),
> > -		int (*error_callback)(int err, void *), struct ns_id *ns, void *);
> > +		int (*error_callback)(int err, struct ns_id *ns, void *), struct ns_id *ns, void *);
> 
> How we are going to use ns in error_callback()?
> 

Well, it is leftover from previous attempts. I'll cleanup.

> > +static int collect_err(int err, struct ns_id *ns, void *arg)
> > +{
> > +	struct sock_diag_greq *gr = arg;
> > +	char family[32], proto[32];
> > +
> > +	/* Fedora 19 hack */
> 
> Pls write more detailed comment here. Fedora 19 is dead for a long time

Hard to tell, I took this code from existing our code base. Probably
we simply should just rip off this comment completely.