[CRIU] [PATCH v2] x86: cpu -- Proceed even if xsavec detected for dev reason

Andrey Vagin avagin at virtuozzo.com
Wed Jun 20 21:21:16 MSK 2018


Appplied, thanks!

On Tue, Jun 19, 2018 at 10:52:21PM +0300, Cyrill Gorcunov wrote:
> Andrew reported that previously he been able to c/r even
> on the machine with xsavec enabled, so allow to process
> for now.
> 
> P.S.I'm investigating the problem and to not block testing
> process lets permit passing with xsaves bit present.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>  criu/arch/x86/cpu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/criu/arch/x86/cpu.c b/criu/arch/x86/cpu.c
> index 11a81863fd8a..d5d879e79f7d 100644
> --- a/criu/arch/x86/cpu.c
> +++ b/criu/arch/x86/cpu.c
> @@ -36,8 +36,9 @@ static int cpu_has_unsupported_features(void)
>  	 * exit early if present.
>  	 */
>  	if (compel_cpu_has_feature(X86_FEATURE_XSAVES)) {
> -		pr_err("Unsupported compact xsave frame on runtime cpu present\n");
> -		return 1;
> +		pr_warn("Unsupported compact xsave frame on runtime cpu present\n");
> +		pr_warn("FIXME: Dazen and confused, but proceed for development reason\n");
> +		return 0;
>  	}
>  
>  	return 0;
> -- 
> 2.14.4
> 


More information about the CRIU mailing list