[CRIU] [PATCH] bitops: use the UL literal for constants

Andrei Vagin avagin at virtuozzo.com
Mon Jun 18 21:11:21 MSK 2018


On Mon, Jun 18, 2018 at 08:10:07PM +0200, Adrian Reber wrote:
> On Mon, Jun 18, 2018 at 10:55:03AM -0700, Andrei Vagin wrote:
> > > I just tested this again and it indeed fixes the cow01 test case. For
> > > aarch64 I am running criu 3.9 with the aarch64 patches on top of it. For
> > > initial testing of this patch I applied the patch on a clean 3.9
> > > checkout without the aarch64 patches so it failed.
> > > 
> > > Now I first applied the aarch64 patches on 3.9 and then this patch and
> > > now everything seems to work correctly on aarch64.
> > > 
> > > Thanks for the patch and sorry for the confusion.
> > 
> > Adrian, thank you for driving this work of supporting aarch64.
> > 
> > Could you check that "./zdtm.py run -a --pre 2" passes without fails
> > too?
> 
> aarch64 does not support dirty memory tracking in the kernel, so I get:
> 
> # ./zdtm.py run -a --pre 2
> Tracking memory is not available
> 
> # git grep "select HAVE_ARCH_SOFT_DIRTY"
> arch/powerpc/Kconfig:   select HAVE_ARCH_SOFT_DIRTY if PPC_BOOK3S_64
> arch/powerpc/Kconfig:   select HAVE_ARCH_SOFT_DIRTY if PPC_BOOK3S_64
> arch/s390/Kconfig:      select HAVE_ARCH_SOFT_DIRTY
> arch/x86/Kconfig:       select HAVE_ARCH_SOFT_DIRTY
> 
> Only on powerpc, s390 and x86 is it implemented in the kernel.

Ok, I see. Thanks!

> 
> 		Adrian


More information about the CRIU mailing list