[CRIU] [PATCH] bitops: use the UL literal for constants

Dmitry Safonov 0x7f454c46 at gmail.com
Mon Jun 18 17:50:46 MSK 2018


2018-06-18 7:50 GMT+01:00 Adrian Reber <areber at redhat.com>:
> Hello Andrei,
>
> I just tested this again and it indeed fixes the cow01 test case. For
> aarch64 I am running criu 3.9 with the aarch64 patches on top of it. For
> initial testing of this patch I applied the patch on a clean 3.9
> checkout without the aarch64 patches so it failed.
>
> Now I first applied the aarch64 patches on 3.9 and then this patch and
> now everything seems to work correctly on aarch64.
>
> Thanks for the patch and sorry for the confusion.
>
>                 Adrian
>
> Tested-by: Adrian Reber <areber at redhat.com>
>
> On Sun, Jun 17, 2018 at 06:44:42AM +0300, Andrei Vagin wrote:
>> We operate by long variables in out bit arithmetics, so our constants
>> should be marked as long too.
>>
>> Cc: Adrian Reber <areber at redhat.com>
>> Reported-by: Adrian Reber <areber at redhat.com>
>> Signed-off-by: Andrei Vagin <avagin at virtuozzo.com>

LGTM,
Reviewed-by: Dmitry Safonov <0x7f454c46 at gmail.com>

Thanks,
             Dmitry


More information about the CRIU mailing list