[CRIU] [PATCH 08/11] compel: cpu -- Add ability to clear features

[Dmitry Safonov]

2018-06-15 14:24 GMT+01:00 Dmitry Safonov <0x7f454c46 at gmail.com>:
> 2018-06-15 14:21 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
>> On Fri, Jun 15, 2018 at 02:10:32PM +0100, Dmitry Safonov wrote:
>>> 2018-06-14 18:27 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
>>> > Will need them to mask some of the features from
>>> > command line options.
>>> >
>>> > Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
>>>
>>> Is there a good reason to copy-paste those two functions over
>>> every architecture?
>>> They look kinda generic and you do not change them in any
>>> following patch.
>>
>> Then we will need some kind of common/ ground for compel.
>> I thought about it and decided to defer such rework.
>> Better clean it up later, when I start implementing support
>> for compacted frames.
>
> Ok well, works for me, probably the next time add something like
> /* TODO: introduce common compel header and merge helpers */
>
> Which would describe it, rather than raise questions :)

I mean, I usually do it, so it won't be forgotten (just grepping
TODO or XXX in code will spoil it).
And it also helps to catch that it wasn't an error (mislooked)
during splitting changes on patches.
Anyway, minor thing :)

-- 
             Dima