[CRIU] Compile errors with 4.18 kernels

[Radostin Stoyanov]

Hi Adrian,

I saw similar errors for the test on fedora rawhidein
     https://travis-ci.org/criupatchwork/criu/jobs/392132369#L2281

In file included from /usr/include/asm/signal.h:26,
from /usr/include/linux/signal.h:5,
from /usr/include/linux/aio_abi.h:32,
from criu/include/aio.h:4,
from criu/pie/parasite.c:22:
/usr/include/asm-generic/signal.h:92:3: error: conflicting types for
'sigset_t'
} sigset_t;
^~~~~~~~

I think this issue can be fixed with:

diff --git a/criu/pie/restorer.c b/criu/pie/restorer.c
index 9b7f6ddb..adddfbf4 100644
--- a/criu/pie/restorer.c
+++ b/criu/pie/restorer.c
@@ -15,7 +15,6 @@
 #include <unistd.h>
 #include <sched.h>
 #include <sys/resource.h>
-#include <signal.h>
 
 #include "linux/userfaultfd.h"
 
 
Kind regards,
Radostin

On 14/06/18 19:20, Adrian Reber wrote:
> As I see it also in travis (https://api.travis-ci.org/v3/job/392077603/log.txt)
> I guess it is known that currently compilation fails on early 4.18
> kernels.
>
>   CC       criu/pie/parasite.o
> In file included from /usr/include/asm/signal.h:7,
>                  from /usr/include/linux/signal.h:5,
>                  from /usr/include/linux/aio_abi.h:32,
>                  from criu/include/aio.h:4,
>                  from criu/pie/parasite.c:22:
> /usr/include/linux/time.h:10:8: error: redefinition of ‘struct timespec’
>
> (and more)
>
> Is this a bug in the kernel or does it need a fix in CRIU? Just curious
> if somebody is looking into it?
>
> 		Adrian
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20180614/f2e452da/attachment-0001.html>