[CRIU] zdtm/static/fd failure on aarch64

Dmitry Safonov 0x7f454c46 at gmail.com
Tue Jun 12 20:00:20 MSK 2018


2018-06-12 17:46 GMT+01:00 Adrian Reber <adrian at lisas.de>:
>
> I thought I tried exactly that, because that is the required fix. This
> also fixes zdtm/transition/maps007. All your other changes are not
> applied right now.
>
> Now only cow01 is failing. Thanks for remote debugging.

Sure, thanks for testing!
Do you want me to send the patch, or will you do it?
Also, I think it's still worth to correct -EWOULDBLOCK => EWOULDBLOCK
and definition of sys_futex(). Like the patch from mail-id:
<CAJwJo6ZGatGFWaYmnk8TyBqBGVPdqVLS1MO3xX4i_x1o4ZjpWw at mail.gmail.com>

>> diff --git a/test/zdtm/lib/arch/aarch64/include/asm/atomic.h b/test/zdtm/lib/arch/aarch64/include/asm/atomic.h
>> index ccf08e700478..ddf4ad9f60e8 100644
>> --- a/test/zdtm/lib/arch/aarch64/include/asm/atomic.h
>> +++ b/test/zdtm/lib/arch/aarch64/include/asm/atomic.h
>> @@ -33,7 +33,7 @@ static inline int atomic_add_return(int i, atomic_t *v)
>>  "    add     %w0, %w0, %w3\n"
>>  "    stlxr   %w1, %w0, %2\n"
>>  "    cbnz    %w1, 1b"
>> -     : "=&r" (result), "=&r" (tmp), "+Q" (v)
>> +     : "=&r" (result), "=&r" (tmp), "+Q" (*v)
>>       : "Ir" (i)
>>       : "cc", "memory");
>>
>> @@ -51,7 +51,7 @@ static inline int atomic_sub_return(int i, atomic_t *v)
>>  "    sub     %w0, %w0, %w3\n"
>>  "    stlxr   %w1, %w0, %2\n"
>>  "    cbnz    %w1, 1b"
>> -     : "=&r" (result), "=&r" (tmp), "+Q" (v)
>> +     : "=&r" (result), "=&r" (tmp), "+Q" (*v)
>>       : "Ir" (i)
>>       : "cc", "memory");
>>

-- 
             Dmitry


More information about the CRIU mailing list