[CRIU] [PATCH] zdtm/static/maps06: removed hardcoded page-size

Dmitry Safonov 0x7f454c46 at gmail.com
Wed Jun 6 17:44:32 MSK 2018


Hi Adrian,

Thanks for doing this!

2018-06-05 20:58 GMT+01:00 Adrian Reber <adrian at lisas.de>:
[..]
> @@ -23,21 +23,26 @@ int main(int argc, char ** argv)
>         if (fd < 0)
>                 return 1;
>
> -       ftruncate(fd, 4096);
> +       ftruncate(fd, ps);
> +
> +       if (ps == 0x1000)
> +               test_size = 10240;
> +       else
> +               test_size = 512;

Is it worth to calculate test_size dynamically based on ps?
Like will the test work on both 16k and 64k pages?

Other than that LGTM,

Reviewed-by: Dmitry Safonov <0x7f454c46 at gmail.com>

-- 
             Dmitry


More information about the CRIU mailing list