[CRIU] [PATCH 00/18] x86: Add support for extendable fpu frames

[Dmitry Safonov]

2018-07-25 21:35 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
> On Wed, Jul 25, 2018 at 09:03:45PM +0100, Dmitry Safonov wrote:
>> 2018-07-24 23:10 GMT+01:00 Andrey Vagin <avagin at virtuozzo.com>:
>> > Dima, could you review this series?
>>
>> Looks good to me, with minor nits, but I think they can be fixed on
>> top afterwards.
>>
>> Cyrill, what do you think, can we add a fault-injection for non-xsave dumping,
>> not to lose the coverage for the older generation? (On the top of these)
>> I expect many modern CPUs have xsaves and we may not notice the
>> breakage.
>
> Thanks a lot for review, Dima! Yes, a few nits here and there, will
> fix on top, since they are not critical.
>
> As to older generation, mind to shed some light what you mean?

Yeah, I mean support for CPU that don't have xsave.

> n.b.:
> Currently we don't require xsave and only fxsave at least, and
> I plan to remove fxsave at all leaving only xsave requirement.

Oh, ok, that way also sounds good to me.
I mean, we either should remove fxsave/fsave code or keep testing it
by adding fault-injection.

-- 
             Dmitry