[CRIU] [PATCH 02/11] nmk: Filter out already seen targets from collect-deps

Cyrill Gorcunov gorcunov at gmail.com
Wed Jul 18 18:28:25 MSK 2018


On Wed, Jul 18, 2018 at 04:16:19PM +0100, Dmitry Safonov wrote:
...
> 
> Ok, but then do we need those lines at all in collect-deps:
> :         ifeq ($(builtin-target),$(1))
> :                deps-y += $(obj-y:.o=.d)
> :        endif
> :        ifeq ($(lib-target),$(1))
> :                deps-y += $(lib-y:.o=.d)
> :        endif
> 
> If your change will add them to deps-y for both cases.

Yes we do, since ifeq and ifneq are different cases. Maybe
this commit might be a way better, agreed. If you prefer
I could clean it up later, the whole series, and resend.
Presumably in a couple of weeks.


More information about the CRIU mailing list