[CRIU] [PATCH 3/8] stats: add a helper to get stats of parent pre-dump

[Dmitry Safonov]

2018-02-09 16:06 GMT+00:00 Pavel Tikhomirov <ptikhomirov at virtuozzo.com>:
> will be used in the next patch
>
> https://jira.sw.ru/browse/PSBM-67502
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
> ---
>  criu/include/stats.h |  2 ++
>  criu/stats.c         | 31 +++++++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+)
>
> diff --git a/criu/include/stats.h b/criu/include/stats.h
> index 81775c856..8694d9fb7 100644
> --- a/criu/include/stats.h
> +++ b/criu/include/stats.h
> @@ -23,6 +23,8 @@ extern void timing_start(int t);
>  extern void timing_stop(int t);
>  extern int timing_uptime(int t);
>
> +extern int get_parent_stats(void **se);

Because dynamic typing and Python are great?
I know, you're trying to decrease nr of includes..
But will that work for you if it's not get_parent_stats(),
but get_parent_uptime() which will return parsed uint64_t?
Then we'll still be able to enjoy C99's static typing..

> +
>  enum {
>         CNT_PAGES_SCANNED,
>         CNT_PAGES_SKIPPED_PARENT,
> diff --git a/criu/stats.c b/criu/stats.c
> index 2944474cd..5c05b1e68 100644
> --- a/criu/stats.c
> +++ b/criu/stats.c
> @@ -213,6 +213,37 @@ void write_stats(int what)
>                 display_stats(what, &stats);
>  }
>
> +__maybe_unused int get_parent_stats(void **se)

Failed to remove __maybe_unused somewhere,
not nice.

-- 
             Dmitry