[CRIU] [PATCH] Fix RPC configuration file handling

Adrian Reber adrian at lisas.de
Fri Dec 14 11:38:15 MSK 2018


On Thu, Dec 13, 2018 at 10:40:52AM -0800, Andrei Vagin wrote:
> On Thu, Dec 13, 2018 at 2:46 AM Adrian Reber <adrian at lisas.de> wrote:
> >
> > From: Adrian Reber <areber at redhat.com>
> >
> > While writing runc test cases to verify that runc correctly uses RPC
> > configuration files it became clear that some things were not working as
> > they are supposed to. Looking closer at the code to set log files
> > via RPC configuration files I discovered that the code seems wrong (at
> > least I did not understand it any more (or the intentions behind it)).
> >
> > This code tries to simplify that logic a bit and add more comments to
> > make clear what the intentions of the RPC configuration file code is.
> 
> Do you know what we have to do to be sure that the codes works as expected? ;)

Good question ;) I will add a test to test/other/rpc to make sure it
works as expected right now and that it will not break in the future. As
the whole RPC configuration file is new it is probably good that we are
now working on runc to figure out how it should actually work.

Do you want the test case being part of this patch or is it okay to send
a new test case independent of this patch (once it is merged).

		Adrian


More information about the CRIU mailing list