[CRIU] [PATCH 0/9] x86: cpu -- Rework feature testing

[Dmitry Safonov]

2018-08-07 17:35 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
>  - Make --cpu-cap options being explicitly bitmask based
>  - Save xsave frame sizes into image
>  - Require xsave frames to exactly match when testing
>
> All this needed to detect a situation where container is migrated
> from one machine to another where xsave frames have different size.
> We already hit the problem where application (for example libc) calls
> for xsave directly and when destination machine is more powerful the
> new bigger size of the frame may override the memory causing programs
> to misbehave.

All the patches look good to me, thanks!
Probably, you could send a bit of detail about the application that crashed
because of libc calling xsave. Just to make sure we will find it on the ML,
if we need.

>
> Cyrill Gorcunov (9):
>   x86: cpu -- Save xsave frame sizes in image
>   x86: cpu -- Make cpu_dump_cpuinfo more readable
>   x86: cpu -- Use bitwise operator for option check
>   x86: cpu -- Move xsave testing into fpu capability block
>   x86: cpu -- Move strict capability mode into own block
>   x86: cpu -- Use special bit for image manipulation
>   x86: cpu -- Update default cpu-cap option
>   x86: cpu -- Add more detailed mode description
>   x86: cpu -- Drop no longer needed early exit from
>     cpu_validate_features
>
>  Documentation/criu.txt    | 14 +++++--
>  criu/arch/x86/cpu.c       | 95 +++++++++++++++++++++++++++++++----------------
>  criu/config.c             |  4 ++
>  criu/cr-dump.c            |  2 +-
>  criu/cr-restore.c         |  2 +-
>  criu/cr-service.c         |  4 +-
>  criu/include/cr_options.h | 13 ++++---
>  images/cpuinfo.proto      |  2 +
>  8 files changed, 91 insertions(+), 45 deletions(-)
>
> --
> 2.14.4
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu



-- 
             Dmitry