[CRIU] [PATCH 1/9] x86: cpu -- Save xsave frame sizes in image

Dmitry Safonov 0x7f454c46 at gmail.com
Mon Aug 20 15:23:44 MSK 2018


2018-08-07 17:35 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
> Keep xsave sizes in image to be sure that on restore
> the application won't override memory out of xsave
> frame size if been calling xsave instruction directly
> (we noticed at least libc did so).
>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>

Reviewed-by: Dmitry Safonov <0x7f454c46 at gmaill.com>

I think it might be worth to add info into commit message about
the application which has crashed, probably glibc function that
does xsave.
Just so we don't guess in the future if we want to change this code.

Thanks,
             Dmitry


More information about the CRIU mailing list