[CRIU] [PATCH 3/3] Documentation/make: Call check before install

Dmitry Safonov dima at arista.com
Mon Apr 30 21:41:58 MSK 2018


Let's warn about binary needed for `install` target.
Before:
[root at localhost criu]# make install
  GEN      crit.1
make[1]: *** [Makefile:49: crit.1] Error 127
make: *** [Makefile.install:32: install-man] Error 2

After:
[root at localhost criu]# make install
/bin/sh: line 1: xmlto: command not found
make[1]: *** [Makefile:32: check] Error 1
make: *** [Makefile.install:32: install-man] Error 2

Fixes: #481
Reported-by: treaki at gmail.com
Signed-off-by: Dmitry Safonov <dima at arista.com>
---
 Documentation/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index de41b3bb25fe..fe640b0ee11e 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -69,7 +69,7 @@ clean:
 	$(call msg-clean, "Documentation")
 	$(Q) rm -f $(XMLS) $(MANS) $(PSS) $(PDFS) $(FOOTER)
 
-install: $(MANS)
+install: check $(MANS)
 	$(E) "  INSTALL " $(MAN8S)
 	$(Q) mkdir -p $(DESTDIR)$(MAN8DIR)
 	$(Q) install -m 644 $(MAN8S) $(DESTDIR)$(MAN8DIR)
-- 
2.13.6



More information about the CRIU mailing list