[CRIU] [PATCHv3 0/7] Large pages support for aarch64/ppc64

Mike Rapoport rppt at linux.vnet.ibm.com
Tue Apr 10 11:08:16 MSK 2018


On Mon, Apr 09, 2018 at 01:10:45PM +0100, Dmitry Safonov wrote:
> Hi Mike,
> 
> 2018-04-09 6:42 GMT+01:00 Mike Rapoport <rppt at linux.vnet.ibm.com>:
> > On Sat, Apr 07, 2018 at 12:40:14AM +0100, Dmitry Safonov wrote:
> [..]
> >> Dmitry Safonov (7):
> >>   criu: Remove PAGE_IMAGE_SIZE
> >>   parasite: Rename misnamed nr_pages
> >>   compel/criu: Add ARCH_HAS_LONG_PAGES to PIE binaries
> >>   criu/dump: Fix size of personality buffer
> >>   criu/log: Define log buffer length without PAGE_SIZE
> >>   criu/proc: Define BUF_SIZE without PAGE_SIZE dependency
> >
> > What about buf[PAGE_SIZE] in crui/mem:restore_priv_vma_content?
> > Do you intend to rely on C99 dynamic arrays or just forgot the patch? ;-)
> 
> Hehe, well, to me it's more stylish patch as it doesn't change behavior.
> I don't mind the patch, but I also do not feel like it's essential or makes
> much difference.
> 
> So, if it looks for you that it would be better with the patch - I'm all for it,
> let's apply it on the top? Will that work for you? :)

I'm ok with dropping it as well.
 
> Thanks,
>              Dmitry
> 

-- 
Sincerely yours,
Mike.



More information about the CRIU mailing list