[CRIU] [PATCH 4/6] kdat: Make sure we're readin cache from tmpfs

Cyrill Gorcunov gorcunov at gmail.com
Thu Apr 5 11:17:01 MSK 2018


On Thu, Apr 05, 2018 at 10:57:57AM +0300, Pavel Emelyanov wrote:
> On 04/03/2018 08:46 PM, Cyrill Gorcunov wrote:
> > When we're saving kdat we check if fs is laying on
> > is on tmpfs thus on machine reboot it get removed
> > and regenerated on next run. Still there is no
> > proof that when we're reading it the underlied
> > fs has not been changed. Lets add this check.
> 
> Can you describe the scenario in which kdat.cache writing happened on tmpfs, while
> reading on non-tmpfs?

I thought I put it into changelog. The fs happen to change for various reasons
(including node operator errors), the check has neglible perf penalty so I think
it worth having it here. The patch series has to be reworked anyway so for
now just drop it.


More information about the CRIU mailing list