[CRIU] [PATCH 4/6] kdat: Make sure we're readin cache from tmpfs

Cyrill Gorcunov gorcunov at gmail.com
Wed Apr 4 11:21:50 MSK 2018


On Tue, Apr 03, 2018 at 07:05:26PM +0100, Dmitry Safonov wrote:
> 2018-04-03 18:46 GMT+01:00 Cyrill Gorcunov <gorcunov at gmail.com>:
> > When we're saving kdat we check if fs is laying on
> > is on tmpfs thus on machine reboot it get removed
> > and regenerated on next run. Still there is no
> > proof that when we're reading it the underlied
> > fs has not been changed. Lets add this check.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> 
> I'm not really sure if we need to care about someone remounting fs
> and placing a copy of criu.kdat over again..
> I don't mind, maybe we should bother, I don't have an opinion about this.
> 
> Anyway, +Cc: Pasha, Andrei, who also introduced this.

Thanks a lot for review, Dima! I'll resend the series one day.


More information about the CRIU mailing list