[CRIU] [PATCH 0/4] s390: Add support for GS and RI control blocks

[Dmitry Safonov]

2017-09-29 8:07 GMT+01:00 Alice Frosi <alice at linux.vnet.ibm.com>:
>
> On 28.09.2017 20:47, Dmitry Safonov wrote:
>>
>> 2017-09-28 12:50 GMT+01:00 Alice Frosi <alice at linux.vnet.ibm.com>:
>>>
>>> This patch set adds s390 support for guarded-storage (GS) and
>>> runtime-instrumentation (RI) control blocks.
>>>   - patch 1/4 adds a function to common code to be able to restore
>>>     registers not present in sigreturn signal frame
>>>   - patch 2/4 adds s390 support for GS control blocks
>>>   - patch 3/4 adds support for RI control block
>>>   - patch 4/4 adds test cases for RI and GS
>>
>> LGTM, but I haven't much experience with s390 GSF/RI things..
>> I would split the 4-th patch on two, but that a minor thing
>> and I guess may go as is.
>
>
> Hi Dmitry,
>
> if you have any question, just write me. Should I split the patch? Let me
> know and in case I will resubmit the patches.
> I kept all together because I added both GS and RI in s390x_regs_check test.

Hi Alice,

"Nice work you've done" I should have said ;-)
No, I don't think it's worth to resend just because of splitting a
patch that adds
tests - let it go as-is.

>
>>> Alice Frosi (4):
>>>    Restore registers not present in the sigreturn signal frame
>>>    s390: Add guarded-storage support
>>>    s390: Add runtime-instrumentation support
>>>    s390: Add test for GS and RI
>>>
>>>   .../s390/src/lib/include/uapi/asm/infect-types.h   |  11 +
>>>   compel/arch/s390/src/lib/infect.c                  | 200 ++++++++++-
>>>   criu/arch/s390/crtools.c                           | 397
>>> +++++++++++++++++++--
>>>   criu/cr-dump.c                                     |  14 +-
>>>   criu/cr-restore.c                                  |  10 +
>>>   criu/include/dump.h                                |   3 +
>>>   criu/include/restore.h                             |   3 +
>>>   images/core-s390.proto                             |  12 +
>>>   test/zdtm/static/Makefile                          |   5 +-
>>>   test/zdtm/static/s390x_gs_threads.c                | 192 ++++++++++
>>>   test/zdtm/static/.c                |  78 ++++
>>>   test/zdtm/static/s390x_runtime_instr.c             | 212 +++++++++++
>>>   12 files changed, 1092 insertions(+), 45 deletions(-)
>>>   create mode 100644 test/zdtm/static/s390x_gs_threads.c
>>>   create mode 100644 test/zdtm/static/s390x_runtime_instr.c
>
>



-- 
             Dmitry