[CRIU] [Announce] CRIU 3.5 "Clay Jay" is out

[Adrian Reber]

On Tue, Oct 17, 2017 at 02:29:43PM -0700, Andrey Vagin wrote:
> On Tue, Oct 17, 2017 at 12:48:26PM -0700, Andrey Vagin wrote:
> > On Tue, Oct 17, 2017 at 04:05:09PM +0200, Adrian Reber wrote:
> > > On Tue, Oct 17, 2017 at 04:56:37PM +0300, Pavel Emelyanov wrote:
> > > > On 10/17/2017 04:36 PM, Adrian Reber wrote:
> > > > > On Tue, Oct 17, 2017 at 03:44:57PM +0300, Pavel Emelyanov wrote:
> > > > >>>>> >From the changelog:
> > > > >>>>>    Use __glibc_reserved1 instead of __reserved.
> > > > >>>>>
> > > > >>>>> And it's not a macro, so we cannot check it with #ifdef :\ IIRC we've seen smth like that
> > > > >>>>> before, again with uc_mcontext.
> > > > >>>
> > > > >>> Has this been fixed? I see that you are preparing for the next release
> > > > >>> and have not seen and follow-up discussion on this.
> > > > >>
> > > > >> Andrey, I thought we had patches about it and they've been pushed to master :)
> > > > >> Have we?
> > > > > 
> > > > > There is only this:
> > > > > 
> > > > > https://github.com/checkpoint-restore/criu/commit/f41e386d4d40e3e26b0cfdc85a812b7edb337f1d
> > > > > 
> > > > > Which is not arch specific. I see no fix for aarch64 on criu-dev.
> > > > 
> > > > Was there a patch for it in the ML?
> > > 
> > > Not from me, as I am not sure how to properly fix it. It probably needs
> > > a feature detection macro to select the right structure name. But I was
> > > not able to get access to the combination of hardware and really new
> > > glibc.
> > 
> > Could you try out the attached patch?
> 
> Here is a correct patch
> https://github.com/avagin/criu/commit/36f3ab45867338e98e43ea5f1f26764ae3946fc2
> 
> In this patch, I declare this structure in a criu header. This should be
> safe, because it is a part of the kernel API.

Thanks, with this patch I can build criu 3.5 on Fedora rawhide aarch64
again: https://koji.fedoraproject.org/koji/taskinfo?taskID=22514565

Tested-by: Adrian Reber <areber at redhat.com>

		Adrian