[CRIU] [PATCH] crtools: also print the current kernel version

[Dmitry Safonov]

I like it!
Just very minor style nitpicks inline.

2017-11-24 10:19 GMT+00:00 Adrian Reber <adrian at lisas.de>:
> From: Adrian Reber <areber at redhat.com>
>
> In addition to writing the CRIU version to the log file this adds the
> current kernel version to the log file:
>
> (00.000008) Version: 3.5 (gitid v3.5-511-ga8cc6cf)
> (00.000303) Running on node01 Linux 3.10.0-513.el7.x86_64 #1 SMP Tue Feb 29 06:78:90 EST 2017 x86_64
>
> Signed-off-by: Adrian Reber <areber at redhat.com>
> ---
>  criu/crtools.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/criu/crtools.c b/criu/crtools.c
> index 293d631..7519269 100644
> --- a/criu/crtools.c
> +++ b/criu/crtools.c
> @@ -21,6 +21,7 @@
>
>  #include <sys/time.h>
>  #include <sys/resource.h>
> +#include <sys/utsname.h>
>
>  #include "int.h"
>  #include "page.h"
> @@ -421,6 +422,19 @@ static void init_configuration(int argc, char *argv[], int defaults_forbidden)
>         }
>  }
>
> +static void kernel_version()

Maybe
static void print_kernel_version(void)

> +{
> +       struct utsname buf;

newline here? ;-)

> +       if (uname(&buf) != 0) {

According to man:
> Upon successful completion, a non-negative value shall be returned.

So, something like that, hm?
if (uname(&buf) < 0) {

(just to be sure that it works with all fancy libcs)

-- 
             Dmitry