[CRIU] Fix warning reported by openSUSE's OBS (Open Build Service)

Andrei Vagin avagin at virtuozzo.com
Tue Nov 14 22:01:59 MSK 2017


Applied, thanks

On Sat, Nov 11, 2017 at 08:11:58PM -0500, Avindra Goolcharan wrote:
> Hi,
> 
> Please find the following patch attached, which removes the shebang
> 
>         -#!/bin/env python2
> 
> from a single file: ( ./lib/py/images/images.py )
> 
> If I am understanding things correctly, images.py can never be
> executed on it's own (i.e., via "./images.py"), so having the shebang
> is superfluous.
> 
> It's a relatively trivial thing but would be nice to have this.
> 
> Here, you can see the build result for the suse rpm is clean:
> 
> https://build.opensuse.org/request/show/541010
> 
> The failures on travis appear to be unrelated, but I'd appreciate a
> pair of more finely tuned eyes there:
> 
> https://travis-ci.org/checkpoint-restore/criu/builds/299831055
> 
> Thanks for reading.
> 
> Regards,
> 
> 
> Avindra.

> From aee84030f4623c468faaa90b8fc0820e39f86bda Mon Sep 17 00:00:00 2001
> From: Avindra Goolcharan <aavindraa at gmail.com>
> Date: Sat, 4 Nov 2017 18:46:03 -0400
> Subject: [PATCH] images.py: remove shebang
> 
> This file is not executable directly, so it should not have the shebang.
> ---
>  lib/py/images/images.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/py/images/images.py b/lib/py/images/images.py
> index bb2f383..b706fd3 100644
> --- a/lib/py/images/images.py
> +++ b/lib/py/images/images.py
> @@ -1,5 +1,3 @@
> -#!/bin/env python2
> -
>  # This file contains methods to deal with criu images.
>  #
>  # According to http://criu.org/Images, criu images can be described
> -- 
> 2.15.0
> Signed-off-by: Avindra Goolcharan <aavindraa at gmail.com>

> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu



More information about the CRIU mailing list