[CRIU] [PATCH 6/8] compel: Do not loose sign of result in compat syscall

Dmitry Safonov 0x7f454c46 at gmail.com
Wed Nov 1 17:08:51 MSK 2017


2017-11-01 13:47 GMT+00:00 Dmitry Safonov <0x7f454c46 at gmail.com>:
> 2017-11-01 13:19 GMT+00:00 Cyrill Gorcunov <gorcunov at openvz.org>:
>> From: Cyrill Gorcunov <gorcunov at virtuozzo.com>
>>
>> Regs are present in unsigned format so convert them
>> into signed first to provide results.
>>
>> In particular if memfd_create syscall failed we won't
>> notice -ENOMEM error but rather treat it as unsigned
>> hex value
>>
>>  | (05.303002) Putting parasite blob into 0x7f1c6ffe0000->0xfffffff4
>>  | (05.303234) Putting tsock into pid 42773
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov at virtuozzo.com>
>
> Reviewed-by: Dmitry Safonov <dima at arista.com>

Andrey, could you check if that fixes
https://github.com/checkpoint-restore/criu/issues/398
on Jenkins, please?
(and add Fixes: #398 on merge if it's so)

Because I have no internet at home yet..
And a bit yet busy with some other relocation stuff.

Thanks,
             Dmitry


More information about the CRIU mailing list