[CRIU] [RESEND v2 2/5] restorer: skip aio restore in check-only mode

Pavel Emelyanov xemul at virtuozzo.com
Wed May 24 06:12:59 PDT 2017


On 05/23/2017 12:42 PM, Adrian Reber wrote:
> From: Adrian Reber <areber at redhat.com>

Can you add a comment saying why AIO should be skipped on check-only restore?

> Signed-off-by: Adrian Reber <areber at redhat.com>
> ---
>  criu/pie/restorer.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/criu/pie/restorer.c b/criu/pie/restorer.c
> index 736c125..f18b76e 100644
> --- a/criu/pie/restorer.c
> +++ b/criu/pie/restorer.c
> @@ -1364,9 +1364,11 @@ long __export_restore_task(struct task_restore_args *args)
>  	 * up AIO rings.
>  	 */
>  
> -	for (i = 0; i < args->rings_n; i++)
> -		if (restore_aio_ring(&args->rings[i]) < 0)
> -			goto core_restore_end;
> +	if (!args->check_only) {
> +		for (i = 0; i < args->rings_n; i++)
> +			if (restore_aio_ring(&args->rings[i]) < 0)
> +				goto core_restore_end;
> +	}
>  
>  	/*
>  	 * Finally restore madivse() bits
> 



More information about the CRIU mailing list